fix(search_family): Fix indexes loading in the FT.SEARCH and Ft.AGGREGATE commands #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
reviewed
Oct 21, 2024
dranikpg
reviewed
Oct 21, 2024
| @@ -80,7 +80,7 @@ search::SortableValue ExtractSortableValueFromJson(const search::Schema& schema, | |||
| } // namespace | |||
|
|
|||
| SearchDocData BaseAccessor::Serialize(const search::Schema& schema, | |||
| const FieldsList& fields) const { | |||
| const SearchFieldsSvList& fields) const { | |||
| SearchDocData out{}; | |||
| for (const auto& [fident, fname] : fields) { | |||
| out[fname] = ExtractSortableValue(schema, fident, absl::StrJoin(GetStrings(fident), ",")); | |||
There was a problem hiding this comment.
Not sure why this turned into "sortable". What is sortable about it? 🙂
There was a problem hiding this comment.
It returns sortable value?
There was a problem hiding this comment.
Yeah, but it's not exclusively used for sorting - that's the confusing part. Its used for all document access. It just returns a document value in one of the value types
BagritsevichStepan
force-pushed
the
df.search/fix-aggregate-load-option-indexes
branch
from
1bd7078 to
15b633c
Compare
…GATE commands fixes dragonflydb#3782, dragonflydb#3659 Signed-off-by: Stsiapan Bahrytsevich <stefan@dragonflydb.io>
BagritsevichStepan
force-pushed
the
df.search/fix-aggregate-load-option-indexes
branch
from
15b633c to
e61afa2
Compare
dranikpg
approved these changes
Oct 27, 2024
BagritsevichStepan
deleted the
df.search/fix-aggregate-load-option-indexes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3782, #3659